Trip sharing #271
Trip sharing #271
Conversation
This is to accommodate the dependent traveler profile. BREAKING CHANGE: Fields from RelatedUser in MonitoredTrip.primary are no longer supported.
…ared trips, add test.
| @@ -176,7 +176,7 @@ public class MonitoredTrip extends Model { | |||
| */ | |||
| public boolean notifyAtLeadingInterval = true; | |||
|
|
|||
| public RelatedUser primary; | |||
| public MobilityProfileLite primary; | |||
| public RelatedUser companion; | |||
| public List<RelatedUser> observers = new ArrayList<>(); | |||
There was a problem hiding this comment.
Probably out of scope, but should any updates to related users be reflected in monitored trips? For instance, if a related user is removed?
There was a problem hiding this comment.
@binh-dam-ibigroup just this to potentially address if you think it is in scope/important?
There was a problem hiding this comment.
@binh-dam-ibigroup just this to potentially address if you think it is in scope/important?
@binh-dam-ibigroup I just need your thoughts on this and then I can approve if it is out of scope.
There was a problem hiding this comment.
@br648 If you are ok with this, we can do delete propagation in another PR.
There was a problem hiding this comment.
@binh-dam-ibigroup I think it is out of scope. Will approve.
src/main/java/org/opentripplanner/middleware/controllers/api/MonitoredTripController.java
Show resolved
Hide resolved
Indeed! |
Checklist
devbefore they can be merged tomaster)Description
Provides a new endpoint to query a given user's monitored trips, including trips on which a user is a companion and or an observer. The field type for
primaryuser is changed toMobilityProfileLiteas a result from introducing the endpoint in #266 for querying the dependent profile.Out of scope: email notifications to users added as companions/observers/primary travelers will be addressed in a separate PR.